Skip to content

[FSSDK-11374] add test cases for impression event and decision listener with holdout support #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 15, 2025

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented May 5, 2025

Summary

  • Add holdout as allowed decision sources
  • Add test cases for impression event
  • Add test cases for decision listener

Test plan

Issues

  • FSSDK-11374

@muzahidul-opti muzahidul-opti changed the title Muzahid/fssdk 11374 [FSSDK-11374] send impression event for holdout May 5, 2025
@muzahidul-opti muzahidul-opti changed the title [FSSDK-11374] send impression event for holdout [FSSDK-11374] add test cases for impression event and notification listener May 5, 2025
@muzahidul-opti muzahidul-opti changed the title [FSSDK-11374] add test cases for impression event and notification listener [FSSDK-11374] add test cases for impression event and decision listener May 5, 2025
@muzahidul-opti muzahidul-opti changed the title [FSSDK-11374] add test cases for impression event and decision listener [FSSDK-11374] add test cases for impression event and decision listener with holdout support May 5, 2025
@muzahidul-opti muzahidul-opti marked this pull request as ready for review May 5, 2025 14:36
@muzahidul-opti muzahidul-opti requested a review from jaeopt May 6, 2025 10:40
Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just pls update the license year.

@muzahidul-opti muzahidul-opti merged commit deb76cd into master May 15, 2025
9 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/FSSDK-11374 branch May 15, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants