Tagging and Data Associations #16
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -86,6 +86,10 @@ dashboards: | |||
| gnetId: 13594 | |||
| revision: 1 | |||
| datasource: Oracle Cloud Infrastructure Metrics | |||
| nvidia-dcgm: | |||
There was a problem hiding this comment.
Snuck this in to give us dcgm dashboard by default
dkennetzoracle
requested review from
CarlDownsOracle,
grantneumanoracle and
vishnukam3
dkennetzoracle
force-pushed
the
data_collection
branch
from
821b752 to
a17bf54
Compare
| count = var.policy_creation_enabled ? 1 : 0 | ||
| depends_on = [oci_identity_dynamic_group.dyn_group] | ||
| freeform_tags = local.corrino_tags | ||
| count = var.policy_creation_enabled ? 1 : 0 |
There was a problem hiding this comment.
This makes me worried... Not everyone installs policies via quickstarts (most I would say install them manually in the console). So if they don't click "Yes" to install the policies, the free_form tags won't get added to the node pools that are created inside the Corrino cluster? We should fix this so that the tags get added regardless.
There was a problem hiding this comment.
Any tagging done here is completely separate from stuff corrino launches with cp. These are tagging resources actually created by the Quickstart - so this specific instance is actually tagging the policies corrino creates. I think I also tag Autonomous DB in the Quickstart terraform deployment.
If you look at the configmap changes, the UUID is always passed, and the cp also has a PR open with all the node and node pool tagging updates. So again - these are unrelated. Maybe it would be easier to explain the overall architecture over a quick chat.
Adding some tagging functionality to OCI resources provisioned by Corrino.