Updated sosreport plugin changes #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orabug: Jira-LSE-524 Signed-off-by: Anil Lal <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
This file is provided by the same RPM that provides corelens. Thus, version checks are superfluous, and calling the rpm command directly seems like the wrong way to get the corelens version anyway. Signed-off-by: Stephen Brennan <[email protected]>
The "-D" option of install needs the filename to be present. Also, the
%files declaration must not include %{buildroot}. Finally, the Python
bytecode files need to be included, but we need to be careful NOT to
declare the entire directory owned by this package: this would result in
RPM deleting the cache directory when our plugin is uninstalled.
Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
biger410
reviewed
Jun 17, 2025
Some Exadata systems seem to name their vmcores <hostname>.vmcore. To ensure that the sosreport plugin works there, we'll use the first file we encounter whose name ends with "vmcore". Signed-off-by: Stephen Brennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are @apalakun's changes (see #155), but with some code style updates, fixes for the spec file, and some simplifications in the code to avoid unnecessary RPM version checks. I have built the RPM and tested
sos report --batchwith vmcores present on OL9, and the corelens report was included in the output -- slick!