[GR-62872] WebAssembly debugger fixes and extensions. #11073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines are no longer looked up based on the function offset, but in the entire range of possible bcis in a function. Simplified reading of entries in the DebugParser and DebugTranslator. Fixed bug, where functions that are no longer in the binary would lead to incorrect debug line mappings. Introduced WasmFunctionBaseNode to support replacement of instrumentable nodes in wasm. Now replaces the WasmFunctionNode when an instrument attaches instead of rewritting the bytecode of the existing one. Made WasmInstrumentationSupportNode PE friendly. # Conflicts: # wasm/src/org.graalvm.wasm/src/org/graalvm/wasm/nodes/WasmFixedMemoryImplFunctionNode.java # wasm/src/org.graalvm.wasm/src/org/graalvm/wasm/nodes/WasmInstrumentableFunctionNode.java
… debug function. The line number program now uses correct file paths. Debug sources now use the full path instead of the file name. Inner contexts now get the io access and polyglot access privileges from their outer context. The mapping of debug source offsets to lines is now represented by line indices instead of lines. This allows for a more compact representation and easier lookup. Debugger can now modify wasm values. Fixed a bug where values in the dwarf debugging format were interpreted as signed instead of unsigned. Debug sources are no longer loaded by wasm. The debugger is now responsible for loading the relevant files. Added support for wasm files when connected to a chrome debugger.
Corrected documentation. DebugArrayDisplayValue and DebugObjectDisplayValue now share ExportMessage implementation.
…t at debug source file. Fixed a potential NPE bug when checking for wasm mime type.
No longer materialize instrumentable nodes that do not point to existing files.
Introduces a test mode for the debugger tests.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.