-
Notifications
You must be signed in to change notification settings - Fork 111
Update metadata for liquibase-core 4.25.0-4.33.0 #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
130faa7 to
4d51137
Compare
tests/src/index.json
Outdated
| "4.27.0", | ||
| "4.28.0", | ||
| "4.29.0" | ||
| "4.29.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not tested, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. These are not tested because this PR was merged after metadata for version 5.0.1 is merged. That all happened before our automation testing workflow. But this list should be reduced only to versions that have metadata directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, all of these are then tested, they are just hidden in the current task as a batch test.
4d51137 to
6484482
Compare
|
LGTM - you've tested those changes against the Spring AOT smoke tests, right? |
@mhalbritter Yes. It did need more manually added entries than in If there are any more issues regarding this, please reach out. |
What does this PR do?
Fixes: #850
This PR addresses metadata issues introduced with merging #666, which resulted in missing metadata for liquibase.core versions 4.25.0-4.33.0. These metadata gaps caused failures in several Spring smoke tests.
To fix these issues, this PR adds the necessary metadata for the affected liquibase.core versions.