Skip to content

Conversation

@kimeta
Copy link
Collaborator

@kimeta kimeta commented Dec 10, 2025

What does this PR do?

Fixes: #850

This PR addresses metadata issues introduced with merging #666, which resulted in missing metadata for liquibase.core versions 4.25.0-4.33.0. These metadata gaps caused failures in several Spring smoke tests.

To fix these issues, this PR adds the necessary metadata for the affected liquibase.core versions.

@kimeta kimeta requested a review from a team as a code owner December 10, 2025 13:10
@kimeta kimeta force-pushed the mm/liquibase-missing-entries-fix branch 2 times, most recently from 130faa7 to 4d51137 Compare December 10, 2025 13:24
@vjovanov vjovanov requested a review from mhalbritter December 10, 2025 16:45
"4.27.0",
"4.28.0",
"4.29.0"
"4.29.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not tested, why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you rebase?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. These are not tested because this PR was merged after metadata for version 5.0.1 is merged. That all happened before our automation testing workflow. But this list should be reduced only to versions that have metadata directories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, all of these are then tested, they are just hidden in the current task as a batch test.

@kimeta kimeta force-pushed the mm/liquibase-missing-entries-fix branch from 4d51137 to 6484482 Compare December 10, 2025 17:06
@mhalbritter
Copy link
Collaborator

LGTM - you've tested those changes against the Spring AOT smoke tests, right?

@kimeta
Copy link
Collaborator Author

kimeta commented Dec 11, 2025

LGTM - you've tested those changes against the Spring AOT smoke tests, right?

@mhalbritter Yes. It did need more manually added entries than in tests/src/org.liquibase/liquibase-core/5.0.1/README.md. Although I cannot test 3.3.x, metadata for liquibase 4.27.0 and 4.29.0 were missing the same entries. After adding them, 4.29.0 had only few more entries, so metadata was basically the same. I merged them into one comprehensive metadata directory.

If there are any more issues regarding this, please reach out.

@kimeta kimeta merged commit ce40086 into oracle:master Dec 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update existing library: org.liquibase:liquibase-core:4.32.0

4 participants