Refactored codebase #292
Merged
Refactored codebase #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
requested changes
Oct 22, 2024
There was a problem hiding this comment.
This is a really useful and massive piece of work you have spearheaded @Achal1607. Thank you very much.
I'm still at the 1/3rd mark of completing the review but I thought I'll publish the 1 minor actionable comment till now.
sid-srini
requested changes
Oct 22, 2024
sid-srini
reviewed
Oct 22, 2024
sid-srini
reviewed
Oct 22, 2024
sid-srini
previously approved these changes
Oct 22, 2024
Achal1607
force-pushed
the
lsp-refactored-code
branch
from
8cbb273 to
12b4f71
Compare
sid-srini
previously approved these changes
Oct 22, 2024
naren2605
reviewed
Oct 23, 2024
naren2605
reviewed
Oct 23, 2024
naren2605
reviewed
Oct 23, 2024
|
thanks for taking up this and refactoring @Achal1607 , its a big change. code looks more organised now |
naren2605
approved these changes
Oct 23, 2024
sid-srini
previously approved these changes
Oct 25, 2024
Achal1607
force-pushed
the
lsp-refactored-code
branch
from
c119f54 to
788bb46
Compare
Fixed tests fixed npm scripts
…ved unused imports
…not reloadingon extension restart fixed no workspace present then extension crashing issue fixed jdk.verbose not working fixed runConfig settings not getting persisted regression and refactored configUpdate and get methods fixed dialog ox appearing when project compile and clean are executed
Achal1607
force-pushed
the
lsp-refactored-code
branch
from
788bb46 to
cffad1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of refactoring was to make code more modular so that it is more readable, scalable and maintainable.
NOTE: Views are yet to be refactored which can be done in a separate PR or included in this only once it is done.