Refactor globalVars into a Separate Class for Improved Encapsulation #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
previously approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Looks fine to me. Thanks @Achal1607.
Perhaps @naren2605 may also review whether this is in line with his previous review. Thanks.
Achal1607
force-pushed
the
globalVars-refactored
branch
from
8c1fa77 to
820a952
Compare
naren2605
reviewed
Oct 29, 2024
…rom namespace to class with appropriate getters and setters Refactored initialization of globalState and updated copyright of extension.ts address review comments
Achal1607
force-pushed
the
globalVars-refactored
branch
from
820a952 to
e7e5ad4
Compare
|
LGTM thanks @Achal1607 for making these changes |
naren2605
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
globalVarsimplementation to improve code structure and encapsulation:Moved
globalVarsfromextension.tsto a Separate FileConverted from Namespace to Class with Getters and Setters
globalVarsis now a class with getter and setter methods, for better encapsulation and allowing controlled access and modification of global state.