Skip to content

[BUGS] Prevent NullPointerException for Gemini models with empty AIMessage content #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YouNeedCryDear merged 3 commits into from
Dec 17, 2025
Merged

[BUGS] Prevent NullPointerException for Gemini models with empty AIMessage content #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab0b7fe
Fix NullPointerException for empty message content
paxiaatucsdedu Dec 10, 2025
4988ee4
Fix tool_call id assignment in ToolCall creation
paxiaatucsdedu Dec 17, 2025
e0eff8b
Make format to appease the lint god
paxiaatucsdedu Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions libs/oci/langchain_oci/chat_models/oci_generative_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,17 @@ def convert_oci_tool_call_to_langchain(tool_call: Any) -> ToolCall:
# If it's not valid JSON, keep it as a string
pass

if "id" in tool_call.attribute_map and tool_call.id:
id = tool_call.id
else:
id = uuid.uuid4().hex

return ToolCall(
name=tool_call.name,
args=parsed
if "arguments" in tool_call.attribute_map
else tool_call.parameters,
id=tool_call.id if "id" in tool_call.attribute_map else uuid.uuid4().hex[:],
id=id,
)

@staticmethod
Expand Down Expand Up @@ -815,7 +820,12 @@ def messages_to_oci_params(
message.tool_calls or message.additional_kwargs.get("tool_calls")
):
# Process content and tool calls for assistant messages
content = self._process_message_content(message.content)
if message.content:
content = self._process_message_content(message.content)
# Issue 78 fix: Check if original content is empty BEFORE processing
# to prevent NullPointerException in OCI backend
else:
content = [self.oci_chat_message_text_content(text=".")]
Copy link
Member

@YouNeedCryDear YouNeedCryDear Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there has to be an arbitrary character in the the text?

Copy link
Member Author

@paxiaatucsdedu paxiaatucsdedu Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tried to use an empty space as the content, but empty space does not work.

tool_calls = []
for tool_call in message.tool_calls:
tool_calls.append(
Expand Down