Skip to content

Azure Vault Config Provider: reject empty secret name #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeandelavarene merged 3 commits into from
Jul 2, 2025
Merged

Azure Vault Config Provider: reject empty secret name #194

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa85a3c
Improve empty secret name validation in Azure Vault Config Provider
MouhsinElmajdouby Jun 13, 2025
1ce3114
Add unit test
MouhsinElmajdouby Jun 16, 2025
ab9fc9c
Address review comment
MouhsinElmajdouby Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...der-azure/src/main/java/oracle/jdbc/provider/azure/configuration/AzureVaultURLParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,15 @@ static void parseVaultSecretUri(

String path = urlBuilder.getPath();

if (!path.contains("/secrets"))
if (!path.contains("/secrets/"))
throw new IllegalArgumentException("The Vault Secret URI should " +
"contain \"/secrets\" following by the name of the Secret: " +
Copy link
Member

@fmeheust fmeheust Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contain "/secrets" followed by the name of the Secret:

vaultSecretUri);

String secretName = path.replace("/secrets", "");
String secretName = path.replace("/secrets/", "");
if (secretName.trim().isEmpty()){
throw new IllegalArgumentException("Missing secret name in Vault URI: " + vaultSecretUri);
}
builder.add("value", KeyVaultSecretFactory.SECRET_NAME, secretName);
}
}
26 changes: 26 additions & 0 deletions .../src/test/java/oracle/jdbc/provider/azure/configuration/AzureVaultSecretProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,32 @@ public void test() {
)));
}

/**
* Verifies that calling getSecret(...) with an empty secret name
* is rejected by throwing an IllegalArgumentException whose message
* indicates a missing secret name.
*/
@Test
public void testEmptySecretNameThrows() {
IllegalArgumentException ex = Assertions.assertThrows(
IllegalArgumentException.class,
() -> PROVIDER.getSecret(
constructSecretProperties(
TestProperties.getOrAbort(AzureTestProperty.AZURE_KEY_VAULT_URL),
"", // <— empty secret path
TestProperties.getOrAbort(AzureTestProperty.AZURE_CLIENT_ID),
TestProperties.getOrAbort(AzureTestProperty.AZURE_CLIENT_SECRET),
TestProperties.getOrAbort(AzureTestProperty.AZURE_TENANT_ID)
)
),
"Expected getSecret(...) to throw when secret name is empty"
);
Assertions.assertTrue(
ex.getMessage().toLowerCase().contains("missing secret name"),
"Exception message should mention 'secret name', but was: " + ex.getMessage()
);
}

private Map<String,String> constructSecretProperties(
String vaultUrl, String secretName, String clientId, String clientSecret, String tenantId) {
Map<String,String> secretProperties = new HashMap<>();
Expand Down