Skip to content

reject blank username/password secrets for gcp #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeandelavarene merged 1 commit into from
Jan 12, 2026
Merged

reject blank username/password secrets for gcp #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...gcp/src/main/java/oracle/jdbc/provider/gcp/resource/GcpSecretManagerPasswordProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ public GcpSecretManagerPasswordProvider() {
public char[] getPassword(Map<Parameter, CharSequence> parameterValues) {
ByteString secret = getSecret(parameterValues);
String password = secret.toStringUtf8();

if (password == null || password.trim().isEmpty()) {
throw new IllegalArgumentException("Password secret content is blank.");
}

return password.toCharArray();
}

Expand Down
7 changes: 6 additions & 1 deletion ...gcp/src/main/java/oracle/jdbc/provider/gcp/resource/GcpSecretManagerUsernameProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ public GcpSecretManagerUsernameProvider() {

@Override
public String getUsername(Map<Parameter, CharSequence> parameterValues) {
return getSecret(parameterValues).toStringUtf8();
String username = getSecret(parameterValues).toStringUtf8();

if (username == null || username.trim().isEmpty()) {
throw new IllegalArgumentException("Username secret content is blank");
}
return username;
}

}