Skip to content

add basic test for PageConfig#getSearchTitle() #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

add basic test for PageConfig#getSearchTitle() #4858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfbfa2
add basic test for PageConfig#getSearchTitle()
vladak Sep 23, 2025
bb37ff7
add test for empty path in getPathTitle()
vladak Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
import org.opengrok.indexer.history.LatestRevisionUtil;
import org.opengrok.indexer.history.RepositoryFactory;
import org.opengrok.indexer.index.Indexer;
import org.opengrok.indexer.search.QueryBuilder;
import org.opengrok.indexer.util.TestRepository;
import org.opengrok.indexer.web.DummyHttpServletRequest;
import org.opengrok.indexer.web.QueryParameters;
Expand Down Expand Up @@ -737,7 +738,6 @@ public String getPathInfo() {
assertEquals("path <foo> - OpenGrok cross reference for /path <foo>", cfg.getPathTitle());
}


@Test
void testGetPathTitleRevision() {
HttpServletRequest req = new DummyHttpServletRequest() {
Expand All @@ -759,6 +759,19 @@ public String getParameter(String name) {
assertEquals("bar (revision 42) - OpenGrok cross reference for /bar", cfg.getPathTitle());
}

@Test
void testGetPathTitleEmptyPath() {
HttpServletRequest req = new DummyHttpServletRequest() {
@Override
public String getPathInfo() {
return "";
}
};

PageConfig cfg = PageConfig.get(req);
assertEquals("/ - OpenGrok cross reference for /", cfg.getPathTitle());
}

@Test
void testGetHistoryTitle() {
HttpServletRequest req = new DummyHttpServletRequest() {
Expand All @@ -771,4 +784,51 @@ public String getPathInfo() {
PageConfig cfg = PageConfig.get(req);
assertEquals("foo <bar> - OpenGrok history log for /foo <bar>", cfg.getHistoryTitle());
}

@Test
void testGetSearchTitle() {
HttpServletRequest req = new DummyHttpServletRequest() {
@Override
public String getPathInfo() {
return "path";
}

@Override
public String getParameter(String name) {
if (name.equals(QueryBuilder.FULL)) {
return "<foo bar>";
}
if (name.equals(QueryBuilder.DEFS)) {
return "<symbol1>";
}
if (name.equals(QueryBuilder.REFS)) {
return "<symbol2>";
}
if (name.equals(QueryBuilder.PATH)) {
return "<path1>";
}
if (name.equals(QueryBuilder.HIST)) {
return "<c6f8b2553cb6bf280acb986b741792d55373de4e>";
}
return null;
}

@Override
public String[] getParameterValues(String name) {
if (name.equals(QueryBuilder.PROJECT)) {
return List.of("<project1>").toArray(new String[0]);
}

return null;
}
};

PageConfig cfg = PageConfig.get(req);
assertEquals("&lt;foo bar&gt; (full), &lt;symbol1&gt; (definition), " +
"&lt;symbol2&gt; (reference), &lt;path1&gt; (path), " +
"&lt;c6f8b2553cb6bf280acb986b741792d55373de4e&gt; (history) " +
"in projects: &lt;project1&gt;" +
" - OpenGrok search results",
cfg.getSearchTitle());
}
}
Loading