Add HLSL language server support (shader-language-server)#1093
Open
TheSmallKiwi wants to merge 4 commits intooraios:mainfrom
Open
Add HLSL language server support (shader-language-server)#1093TheSmallKiwi wants to merge 4 commits intooraios:mainfrom
TheSmallKiwi wants to merge 4 commits intooraios:mainfrom
Conversation
…a file When request_full_symbol_tree processes all project files, a language server crash on a single file (e.g. complex HLSL shaders) would propagate up and abort the entire search. Now catches SolidLSPException per-file, logs a warning, and auto-restarts the LS if it terminated so remaining files can still be processed. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Fix is_ignored_dirname to call super() so dot-directories are properly excluded during workspace walks. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
shader-language-server only publishes binaries for Windows and Linux. Add availability check and skipif decorators following the existing pattern (erlang, clojure, cpp). Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.hlsl,.hlsli,.fx,.fxh,.cginc,.compute,.shaderfile extensionsrequest_full_symbol_tree()to catchSolidLSPExceptionper-file so a single LS crash doesn't abort the entire workspace scanWhat's included
HlslLanguageServerclass with dependency provider, initialize params, and Unity-specific directory ignore listLanguage.HLSLenum entry with file matchers and factory methodis_ignored_dirnameto callsuper()so dot-directories (.git,.serena, etc.) are properly excludedTest plan
uv run poe test -m hlsl— all 12 tests passuv run poe format— cleanuv run poe type-check— clean🤖 Generated with Claude Code