-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Pywebview nix #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MischaPanch
wants to merge
2
commits into
pywebview
Choose a base branch
from
pywebview-nix
base: pywebview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pywebview nix #1256
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,9 @@ Both can be configured in Serena's [configuration](050_configuration) file (`ser | |
| The dashboard is a web application, which is opened via a native application wrapper on Windows and macOS, | ||
| where it will appear in the system tray. **Click on the tray icon** to open the application window. | ||
|
|
||
| On Linux, native app support is difficult to provide, so the dashboard will be opened in your default web browser instead. | ||
| On Linux, native app support requires GTK 3 and WebKit2GTK. When running Serena via the [Nix flake](nix-usage), | ||
| these libraries are bundled automatically, so the native dashboard viewer (with system tray) works out of the box. | ||
| Without the Nix wrapper, the dashboard will be opened in your default web browser instead. | ||
|
|
||
| By default, the dashboard can be accessed at `http://localhost:24282/dashboard/index.html`, | ||
| but a higher port may be used if the default port is unavailable/multiple instances are running. | ||
|
|
@@ -61,7 +63,7 @@ to the `start-mcp-server` CLI command. | |
| On Windows and macOS, you can conveniently open the dashboard at any time by clicking on the tray icon, so automatic | ||
| opening is not a requirement to be able to access the dashboard on these platforms. | ||
|
|
||
| On Linux, access to the dashboard is more cumbersome without native app support. | ||
| On Linux without the Nix wrapper, access to the dashboard is more cumbersome without native app support. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps add link to Nix section. |
||
| Yet you may still access it by | ||
| * asking the LLM to "open the Serena dashboard", which will open the dashboard in your default browser | ||
| (the tool `open_dashboard` is enabled for this purpose, provided that the dashboard is active, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording is inaccurate, implying that these specific libraries are required (and that their installation could perhaps in general enable GUI support).
Suggestion:
On Linux, native app support is difficult to provide in general, as it requires a desktop environment with corresponding UI framework libraries pre-installed.
When running Serena via the Nix flake, suitable libraries are bundled automatically and Serena will make use of them, such that the native dashboard viewer (with system tray) works out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very much a draft, made by Claude. I just want to check whether it runs on my linux laptop (hence the WIP as PR description)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but since I was looking at this out of interest, I thought I'd directly remark on the improvements that came to my mind.