feat: add BSL (1C Enterprise) context#1379
Open
Alex1980Alex wants to merge 4 commits intooraios:mainfrom
Open
Conversation
- Add BSL language server implementation - Update project configuration for BSL support - Add test resources and BSL-specific tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add opt-in context for 1C:Enterprise BSL development with: - Cyrillic-aware identifier guidance - BSL-specific tool allowlist (symbol navigation, pattern search) - Shell command excluded (no REPL equivalent) Closes oraios#1378 Co-Authored-By: Claude Opus 4.7 <[email protected]>
MischaPanch
requested changes
Apr 20, 2026
Contributor
There was a problem hiding this comment.
Thanks for the PR.
I don't think we need a separate context, the bsl server won't be started if there are no bsl files in the project.
I fixed the formatting to allow CI to start, but even before a proper review I see that the tests are completely off. Pls fix them, then I will re-review
- Never use try-skip, this masks failures. Same for
if len(symbols) > 0: - Never have tests just asserting the type of the result, always assert the content
- A test uses the not-existing method
request_workspace_symbols - Tests use an older api and hence the wrong types (would be caught by a type checker), e.g.
symbols = language_server.request_document_symbols(file_path)should be replaced bysymbols = language_server.request_document_symbols(file_path).get_all_symbols_and_roots()[0] - Tests need to run in CI, pls add a setup step for BSL language server there
Contributor
|
Note that this fork implements BSL support, maybe useful as a reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in BSL (1C:Enterprise) context configuration for Serena.
Closes #1378
Changes
src/serena/resources/config/contexts/bsl.ymlThe context provides:
execute_shell_commandexcluded (BSL has no REPL equivalent)Why opt-in
BSL is a niche language compared to Python/TS/Go/Rust. This context activates only via
--context bsl, ensuring zero impact on default Serena behavior while providing value to 1C:Enterprise developers.The Serena codebase already includes experimental BSL Language Server support (
bsl_language_server.py). This context complements it with BSL-specific tooling guidance.Testing
agent.yml,codex.ymlpatterns)Checklist
execute_shell_commandexcluded (appropriate for BSL)