Switch to oci_spec's arch and os implementation #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toksdotdev
requested review from
bacongobbler,
flavio and
thomastaylor312
as code owners
Signed-off-by: Tochukwu Nkemdilim <[email protected]>
toksdotdev
force-pushed
the
toks/string-impl-for-enums
branch
from
093efc9 to
77bdd02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches switches the os and arch representation to that of
oci_spec's, which makes it easy to work with both crates. This is somewhat of a breaking change, and would require callers to update corresponding fields on version bump.