New module oracle_sqldba for "sqlplus / as sysdba" and catcon.pl #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut content, dependencies, and UPI (unique patch ID) differ. These patches have to be rolled back in advance of applying the PSU/RU and must afterwards be installed with the correct version (=UPI). They should however not be rolled back if they are already there with the desired UPI. This helps to write more idempotent playbooks. So there is a new parameter exclude_upi that is evaluated only if state=absent. To keep changes in working code at a minimum the check for UPI could be acquired only by another "opatch lspatches" that costs some seconds.
Oracle_opatch searches the running listener with: ```ps -elf | grep "[0-9] $ORACLE_HOME/bin/tnslsnr"``` ...then splits the line by spaces and takes the last but one field. This does not work for a "ps -ef" result like this: ```0 S oracle 16921 1 0 80 0 - 43851 ep_pol 21:58 ? 00:00:00 /u01/app/oracle/product/12.1.0.2/ee/bin/tnslsnr LISTENER /dev/null -inherit``` In this case "linelist[-2]" deliveres "/dev/null" instead of the LISTENER name. My fix is to search the ps line for the listener executable and use the next field.
Signed-off-by: Dietmar Uhlig <[email protected]>
Signed-off-by: Dietmar Uhlig <[email protected]>
(I should have tested more thoroughly after the last refactoring.)
|
Hi, I'm sorry I haven't gotten back to you regarding this PR. I really appreciate you taking the time to contribute, and I'll look at this as soon as I can but I'm completely swamped at the moment (and have been for a while). I'll get back to you as soon as I can. Thanks! |
|
No problem. There's no rush. KR, Dietmar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should contain commit 031b16a only. But it contains other unrelated commits covered by PR #122 and #123. Sorry for that.
There were some requests for oracle_sql connecting password-less, i.e. "/ as sysdba". I see these requests in a wider context. I needed to group post-installation (and up to DB 12.1 also post-patch) tasks. They are a mixture of sql scripts, sql commands, and catcon calls. So I created a new module "oracle_sqldba". This module contains a loosely related feature: to execute a sql query and return the results in a python dict. Examples are in the module's comments section.
The module definitely needs testing. But at least it workes for my purposes.