Report failures properly for oracle_user
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of the code in `oracle_user` was passing around `msg` as if its contents could be modified by assignment (they can't be). I removed all of the faulty `msg`-passing and made critical functions fail properly if necessary. The net result is that, on failure, there will always be a proper `msg` provided. Previously, this would often result in an empty message, which is very difficult to troubleshoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the code in
oracle_userwas passing aroundmsgas if its contents could be modified by assignment (they can't be). I removed all of the faultymsg-passing and made critical functionsfail properly if necessary.
The net result is that, on failure, there will always be a proper
msgprovided. Previously, this would often result in an empty message, which is very difficult to troubleshoot.