Skip to content

fix(types): avoid unnecessary namespace for UsageDiscount #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sskhandek merged 1 commit into from
Jan 7, 2025
Merged

fix(types): avoid unnecessary namespace for UsageDiscount #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions src/resources/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,24 @@ export interface AmountDiscount {

export type BillingCycleRelativeDate = 'start_of_term' | 'end_of_term';

export type Discount = PercentageDiscount | TrialDiscount | Discount.UsageDiscount | AmountDiscount;

export namespace Discount {
export interface UsageDiscount {
/**
* List of price_ids that this discount applies to. For plan/plan phase discounts,
* this can be a subset of prices.
*/
applies_to_price_ids: Array<string>;

discount_type: 'usage';

/**
* Only available if discount_type is `usage`. Number of usage units that this
* discount is for
*/
usage_discount: number;

reason?: string | null;
}
export type Discount = PercentageDiscount | TrialDiscount | UsageDiscount | AmountDiscount;

export interface UsageDiscount {
/**
* List of price_ids that this discount applies to. For plan/plan phase discounts,
* this can be a subset of prices.
*/
applies_to_price_ids: Array<string>;

discount_type: 'usage';

/**
* Only available if discount_type is `usage`. Number of usage units that this
* discount is for
*/
usage_discount: number;

reason?: string | null;
}

export type InvoiceLevelDiscount = PercentageDiscount | AmountDiscount | TrialDiscount;
Expand Down
Loading