v0.0.118 custom #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change the Bolt12Invoice struct to carry a tagged hash. Because message_digest is then only used in one place, we can inline it in the TaggedHash constructor.
Expose tag and merkle root fields in the TaggedHash struct.
orbitalturtle
added a commit
to lndk-org/ldk-sample
that referenced
this pull request
Nov 15, 2023
As described in orbitalturtle/rust-lightning#2 we need to temporarily bump rust-lightning dependencies to avoid dependency conflicts in lndk.
orbitalturtle
added a commit
to lndk-org/ldk-sample
that referenced
this pull request
Nov 15, 2023
As described in orbitalturtle/rust-lightning#2 we need to temporarily bump rust-lightning dependencies to avoid dependency conflicts in lndk.
orbitalturtle
added a commit
to lndk-org/ldk-sample
that referenced
this pull request
Nov 22, 2023
As described in orbitalturtle/rust-lightning#2 we need to temporarily bump rust-lightning dependencies to avoid dependency conflicts in lndk.
orbitalturtle
added a commit
to lndk-org/ldk-sample
that referenced
this pull request
Dec 6, 2023
As described in orbitalturtle/rust-lightning#2 we need to temporarily bump rust-lightning dependencies to avoid dependency conflicts in lndk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch we just update to a specific hash of rust-lightning with the taggedhash tweaks we need for ldk-sample/lndk. We need the Cargo.toml changes to make sure we're using the exact same rust-lightning dependency everywhere, else we get version conflict errors in lndk.
We'll just use this temporary branch until ldk v119 comes out :)