Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Fix Postfinance import #535

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Fix Postfinance import #535

merged 2 commits into from
Nov 16, 2020

Conversation

patrickvenetz
Copy link
Contributor

Array insertPromises might be an empty array.

Setting initial value prevents error "Reduce of empty array with no initial value".
…eport

Finance is canceling pledges at their own discretion and find action required notice unhelpful.
Copy link
Contributor

@tpreusse tpreusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I personally would have kept a cancel count. But I guess ultra dashboard is pretty good at counts too :)

One more thing

Could we suppress send reminder runs unless there has been an import the same day? We can check for that by looking for an entry in postfinanceImports with createdAt today. Should be done in the runner in the morning and the one at 12:00.

This should reduce cases where the reminder arrives after the payment is issued but still being processed.

@patrickvenetz
Copy link
Contributor Author

@caillou

I wonder why this did not generate a TS error in the first place?

Good question, I shall look into that.

@patrickvenetz
Copy link
Contributor Author

@tpreusse

One more thing

I understand your intent and shall deliver something feisty in a subsequent pull request.

@caillou
Copy link
Contributor

caillou commented Nov 16, 2020

@caillou

I wonder why this did not generate a TS error in the first place?

Good question, I shall look into that.

You will end up sad: microsoft/TypeScript#34736

@patrickvenetz
Copy link
Contributor Author

@caillou

I wonder why this did not generate a TS error in the first place?

Good question, I shall look into that.

You will end up sad: microsoft/TypeScript#34736

Fair enough.

@patrickvenetz patrickvenetz merged commit 9cd0660 into master Nov 16, 2020
@patrickvenetz patrickvenetz deleted the pae/fix-postfinance-import branch November 16, 2020 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants