[DO NOT MERGE] Enable block storage init test#1569
Draft
Conversation
Contributor
|
@netoneko, Should we ask @itamararjuan to look into this when he gets some time? |
Contributor
|
@netoneko I believe the reason this is failing is that we need a different blocks file for lean-helix - the block proofs will look different |
Contributor
Author
|
@ronnno seems like a reasonable assumption, but when we run regular e2e we also copy the blocks in |
Contributor
|
you are right - i think the only way is to generate two versions of the blocks file - one for lean helix and one for benchmark consensus. I will add this second file to this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables block storage init test per @ronnno suggestion.
The test still fails on CI, needs additional investigation why.