chore: move to esm-env instead of esm-env-robust #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR sveltejs/sites#445 is merged, fixing benmccann/esm-env#1, but still not deployed. After the change will finally be deployed to the official svelte.dev site, we can merge this changes safely.
|
Update: Sadly it will take more time, since they need to fix styling before they deploy the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR sveltejs/sites#445 is merged, fixing benmccann/esm-env#1, but still not deployed.
After the change will finally be deployed to the official svelte.dev site, we can merge this changes safely.
A simple reproduction to check if svelte.dev has the fix deployed, is to see if this example builds up correctly:
https://svelte.dev/repl/58ae14b7f112454aa83125b767f9a62a?version=3.54.0
@orefalo don't merge until they deploy it