-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yarn command syntax in CLI commands #242
base: main
Are you sure you want to change the base?
Conversation
@aymanch-03 is attempting to deploy a commit to the Cruip Team on Vercel. A member of the Team first needs to authorize it. |
#229 would be helpful if you tag the issue along with it no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the PR is wrong, should be yarn dlx as mentioned in the issue #229
yarn: npx yarn dlx shadcn@latest add https://originui.com/r/${name}.json
yarn: yarn dlx shadcn@latest add https://originui.com/r/${name}.json
well npx
works, good work @aymanch-03
@pasqualevitiello I can see dbb0c5b, it was yarn dlx before, you switched it to npx, I am not using yarn anymore, so would like to learn your findings about it |
microsoft/playwright#15369 (comment) seems to answer some of my concerns, closing my issue #229 |
ohh sorry, @pasqualevitiello the pull request is legit, you have it like |
@nrjdalal Sorry, I didn't notice the issue you opened. Thanks for the good work! |
This PR resolves an issue with the yarn CLI command used for installing components. The previous implementation had incorrect syntax, which has now been fixed.
File Updated:
cli-commands.tsx