rtt_roscomm: add rtt_roscomm namespace for rosservice plugins and helper classes #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classes related to service plugins were not declared in a namespace in package
rtt_roscommand derivedrtt_std_srvs. The risk of name collisions was low because of the very specific class names, but nevertheless it is a good and recommended practice in ROS to use the package name as a C++ namespace.Users who already applied the new service-operation caller signature wrapper feature (#123) to custom services have to add the
rtt_roscommnamespace when specializingROSServiceServerOperationCallerWrapper<T, variant>for the specific ROS service.This patch breaks ABI-compatibility and should not be part of a ROS kinetic release. No problem for source builds.