Skip to content

feat: add throwOnError option to generate function #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chu0119 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add throwOnError option to generate function #3362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,7 @@ export interface GlobalOptions {
input?: string | string[];
output?: string;
failOnWarnings?: boolean;
throwOnError?: boolean;
}

export interface Tsconfig {
Expand Down
9 changes: 9 additions & 0 deletions packages/orval/src/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
await generateSpec(workspace, normalizedOptions, projectName);
} catch (error) {
hasErrors = true;
if (options?.throwOnError) {
throw error;
}
logError(error, projectName);
Comment on lines +42 to 45
}

Expand Down Expand Up @@ -88,6 +91,9 @@
try {
await generateSpec(workspace, normalizedOptions);
} catch (error) {
if (options?.throwOnError) {
throw error;
}
logError(error);
}

Expand All @@ -99,6 +105,9 @@
try {
await generateSpec(workspace, normalizedOptions);
} catch (error) {
if (options?.throwOnError) {

Check failure on line 108 in packages/orval/src/generate.ts

View workflow job for this annotation

GitHub Actions / pr-checks (ubuntu-latest, 22.x) 

Unnecessary optional chain on a non-nullish value
throw error;
}
logError(error);
}
if (options.failOnWarnings && getWarningCount() > 0) {
Expand Down
Loading