Skip to content

feat: import TOTP credentials #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: import TOTP credentials #2349

wants to merge 1 commit into from

Conversation

@deepakprabhakara
Copy link
Contributor

@deepakprabhakara deepakprabhakara commented Nov 19, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@deepakprabhakara deepakprabhakara added the upstream Issue is caused by an upstream dependency. label Nov 19, 2025
@deepakprabhakara deepakprabhakara changed the title feat: TOTP credentials import feat: import TOTP credentials Nov 19, 2025
vinckr
vinckr reviewed Nov 19, 2025
View reviewed changes
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Only thing is the table of contents location - at the moment it is grouped under the "Organizations specific credentials" - I guess this would be more "general" though?
If yes then please move it up under the SAML connections.

see screenshot
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinckr vinckr vinckr left review comments

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@deepakprabhakara deepakprabhakara

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deepakprabhakara @vinckr