Skip to content

Conversation

@emliunix
Copy link

The index pages in examples contains outdated self links to examples.

  • branches: master -> main
  • app-router-example falsely points to pages-router-example

Related Issue or Design Document

n/a

Checklist

  • [ x] I have read the contributing guidelines and signed the CLA.
  • [ x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [ x] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ x] I have added tests that prove my fix is effective or that my feature works.
  • [ x] I have added the necessary documentation within the code base (if appropriate).

Copilot AI review requested due to automatic review settings October 31, 2025 23:47
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: 417ce78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 31, 2025

@emliunix is attempting to deploy a commit to the ory Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub repository URLs to reflect the branch name change from "master" to "main" and corrects the paths to point to the appropriate example directories. The changes ensure that links to the App Router and Pages Router examples are accurate and use the current default branch name.

Key changes:

  • Updated branch name from "master" to "main" in GitHub URLs
  • Fixed incorrect paths to ensure each example links to the correct directory

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/nextjs-pages-router/pages/index.tsx Updated GitHub URLs to use "main" branch and corrected the App Router example path
examples/nextjs-app-router/app/page.tsx Updated GitHub URLs to use "main" branch and corrected the App Router example path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.47%. Comparing base (f3fad4d) to head (417ce78).
⚠️ Report is 261 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #579       +/-   ##
===========================================
+ Coverage   42.43%   54.47%   +12.04%     
===========================================
  Files         136      159       +23     
  Lines        2008     3042     +1034     
  Branches      288      461      +173     
===========================================
+ Hits          852     1657      +805     
- Misses       1149     1323      +174     
- Partials        7       62       +55     
Components Coverage Δ
@ory/elements-react 53.00% <ø> (+16.21%) ⬆️
@ory/nextjs 62.52% <ø> (-3.46%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm :shipit:

@vercel
Copy link

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elements-nextjs-app-router Ready Ready Preview Comment Nov 18, 2025 11:48am
elements-nextjs-pages-router Ready Ready Preview Comment Nov 18, 2025 11:48am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants