Track the relevant scheduled product when a job is obsoleted #6134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Jan 23, 2025
Martchus
commented
- Add the ID of the new scheduled product that is obsoleting jobs as reason so we know whether a job has been canceled due when scheduling a product and by which
- Improve and extend test code, e.g. fix wrong 'two jobs cancelled …' when it should be 'three …'
- See https://progress.opensuse.org/issues/174583
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6134 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 396 396
Lines 39628 39637 +9
=======================================
+ Hits 39228 39237 +9
Misses 400 400 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Jan 23, 2025
Wabri
requested changes
Jan 23, 2025
* Add the ID of the new scheduled product that is obsoleting jobs as reason so we know whether a job has been canceled due when scheduling a product and by which * Improve and extend test code, e.g. fix wrong 'two jobs cancelled …' when it should be 'three …' * See https://progress.opensuse.org/issues/174583
Martchus
force-pushed
the
track-cancellation
branch
from
88ab02e to
543ae13
Compare
okurz
approved these changes
Jan 24, 2025
Wabri
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.