Support OpenID Connect better in the OAuth2 'custom' provider. #6154
Conversation
ssssam
force-pushed
the
sam/fix-custom-oauth2-provider
branch
2 times, most recently
from
3033a91 to
5295acb
Compare
ssssam
force-pushed
the
sam/fix-custom-oauth2-provider
branch
from
5295acb to
131b279
Compare
The OpenID Connect standard specifies that `sub` contains the user ID. Until now, openQA only looked for a field named `id`. When using Keycloak as identity provider there is no such field, it returns only `sub` as expected in OpenID Connect. To avoid breaking any existing configs, this patch adds a new `id_from` config field which defaults to `id`, so existing behaviour is preserved. Set `id_from = sub` in the OAuth2 provider config to get the new behaviour. Fixes: os-autoinst#5771
ssssam
force-pushed
the
sam/fix-custom-oauth2-provider
branch
from
131b279 to
3eba657
Compare
|
Looks like the Codecov check couldn't be triggered. The related CircleCI job ran for "0 s" and if one clicks on the job one gets only "Something Unexpected Happened". All buttons for re-running are grayed out and the workflow status is also "Error" (and not e.g. "Failed"). So I suppose the easiest way to get green checkmarks on the CI is to amend the commit and force-push again. |
ssssam
force-pushed
the
sam/fix-custom-oauth2-provider
branch
from
3eba657 to
1115a51
Compare
|
The CI checks failed (or rather "errored") in the same way as before despite the commit being based on a recent commit from master. I also tried to re-deliver the webhook to CircleCI but it didn't have any effect. Maybe we can merge this forcefully considering all steps of the CircleCI pipeline worked except Codecov? Otherwise you would probably need to create a new PR. |
|
I created as a re-submit which might help to trigger the codecov report generation |
|
Merged as part of thank you for the contribution! |
The OpenID Connect standard specifies that
subcontains the user ID. Until now, openQA only looked for a field namedid.When using Keycloak as identity provider there is no such field, it returns only
subas expected in OpenID Connect.To avoid breaking any existing configs, this patch adds a new
id_fromconfig field which defaults toid, so existing behaviour is preserved. Setid_from = subin the OAuth2 provider config to get the new behaviour.