CDN Features for files uploaded to system #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the search_base is not defined or not correct for the user being authenticated and a search user and password is given and is correct, attempt to lookup the user's DN and authenticate as the found DN with the given password.
Add the "Telephone Number" field on the "General" tab of the Windows user manager dialog to the "Phone Number" field of the user-to-be-created when adding users from the LDAP directory into the system.
If the DNS servers were not considered, the empty string would be interpreted as a list of one DNS server with an empty IP address. Therefore, the name servers specified in the system DNS configuration would not be used. This patch corrects the issue by filtering empty DNS server specifications.
This is necessary so we can split Staff/User authentication.
(For when we get there)
Authentication Backends Revisited Reviewed-By: Jared Hancock <[email protected]>
Add plugin builder script to create PHAR files
Previously the DN length was capped at 80 chars. This patch allows specification of up to 120 chars.
ldap: Allow specification of extremely long DNs
ldap: AD: Add validation errors
Also search for inetOrgPerson objectClass objects for standard LDAP systems rather than assuming that all users have the posixAccount class as well.
display some more information to the admin user configuring the plugin
Use composer to download and manage dependencies
Attachment storage in Amazon S3 Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: protich <[email protected]>, JediKev <[email protected]>
Reviewed-By: protich <[email protected]>, JediKev <[email protected]>
Reviewed-By: protich <[email protected]>, JediKev <[email protected]>
Reviewed-By: protich <[email protected]>, JediKev <[email protected]>
This resolves and issue where when hydrating the S3 plugin it's still including uneeded dependencies even though the plugin info includes the script and extra tags. This is due to `make.php` not taking those into account when resolving the dependencies. This updates the `resolveDependencies` method to account for the scripts and extra tags and will include them if found. This also addresses an small issue where the extra value needs to be an array otherwise it causes fatal error.
…s-and-extra Reviewed-By: Peter Rotich <[email protected]>
This adds the OAuth2 Authentication defaults for Okta provider. This will make Okta setup a little easier.
This is the second part to the main core pull that fixes an issue where using any other language than English and attempting to export `All` events for a specific object fails. This removes the translation method from the instances that do not need it and cause issues.
This addresses PHP 8.1 compatibilty issues with the LDAP plugin. Since the LDAP resources were converted to LDAP\Connection, LDAP\Result, and LDAP\ResultEntry objects respectively, the previous `is_resource()` checks fail. This updates all relevant cases of `is_resource()` to `!== false` checks to make LDAP plugin compatible with PHP 8.1.
This addresses an error reported in 270 where we are attempting to call `dn()` on `$r->current()` but `current()` can sometimes return `false`. This adds a check for `!$r->current()` before continuing to `dn()`. See similar issue here: 260
Reviewed-By: JediKev <[email protected]>
Reviewed-By: JediKev <[email protected]>
Reviewed-By: JediKev <[email protected]>
Reviewed-By: JediKev <[email protected]>
This is a commit that goes along with a core commit for password length. We should limit passwords to minimum of 1 and maximum of 128.
Reviewed-By: JediKev <[email protected]>
This addresses an issue where `ldap://` and `ldaps://` gets stripped from the hostname by weak REGEX. This updates the REGEX to make it account for `ldap://` and `ldaps://` so that it remains as part of the hostname. This will allow people to typehint LDAPS connections.
Reviewed-By: Peter Rotich <[email protected]>
…nt-selection-prompt Reviewed-By: Peter Rotich <[email protected]>
This updates Net_LDAP2 from v2.2.1 to v2.3.0.
This simply updates the available S3 Zones to add any missing zones.
This addresses an issue where if you have more than one LDAP instance running it will show "Active Directory or LDAP" for all instances making it hard to differentiate the instances. This updates the `getName()` function to grab the name from the config if available otherwise defaults to the default name.
This commit started with me trying to address cross-resource issue with Microsoft Outlook and Graph endpoints and ended up being a plugin rewrite. Some of the changes include; * Making getting Resource Owner Optional - this was especially necessary for Microsoft Email provider * Added support for providers specifying custom Config class * Extend League AccessToken so we can best manage Token object e.g getting resource owner attributes * Added ability to decode jwt token to get resource owner info when getting resource owner is not an option (Thanks to M$) * Updated default endpoints as needed
When adding a new instance of MicrosoftEmailOauth2 the core validates data using default plugin config form instead of the custom one. This commit addresses the issue temporarily by injecting resource owner url for validation purpose only. In the upcoming version of core we will accept either a form or vars - making it possible to support older plugins until end of life is reached.
Reviewed-By: Peter Rotich <[email protected]>
Reviewed-By: Peter Rotich <[email protected]>
S3: Update Available Zone (2024)
Reviewed-By: Peter Rotich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you add this functionality o a script of php, just like the CDN rules that transfer or store all files on another server? Currently base on the plugin available, it oly store data in a folder. This will be a big help for a small storage server.