Skip to content

Adds IP based authentication #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

webermax
Copy link

@webermax webermax commented Nov 6, 2015

Adds the possibility to authenticate users based on their IP address. This is especially useful for intranet solutions.

@Chefkeks
Copy link
Contributor

Chefkeks commented Nov 6, 2015

Definitely a neat plugin. Haven't tested it, but looking at the code I saw you misspelled a word in config.php on line 24: "identifie" ... I guess this shall be "identified"

@webermax
Copy link
Author

webermax commented Nov 6, 2015

Thx, I fixed it.

The IP auth plugin is a modification of the auth passthrough plugin.

@Chefkeks
Copy link
Contributor

Chefkeks commented Nov 6, 2015

You're welcome!

Und schöne Grüße nach München :D

@greezybacon
Copy link
Contributor

@webermax thanks for taking the time to write a plugin. I have a couple questions about it:

  • What would be the use case for the plugin? You seem to accept a couple arguments from the URL parameters ($_GET), but there seems to be very little checking on its validity. There's also no configuration parameters for what ip ranges or such would be acceptable.
  • Seems like I could get in as an administrator by simple passing ?token=admin in the URL. Is that correct?
  • You have a configuration option to enable client SSO, but you don't seem to check to see if it's enabled before signing in clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants