Use device flow as the default OAuth flow for login #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device flow is more likely to succeed than the code flow because it doesn't require the CLI and the authorization server to agree on a redirect URI. Additionally, the device flow doesn't require the CLI to bring up an HTTP server to receive the authorization code, which can also fail in certain environments. Users can still explicitly request the code flow with `--oauth-flow=code` if desired. Signed-off-by: Juan Hernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device flow is more likely to succeed than the code flow because it doesn't require the CLI and the authorization server to agree on a redirect URI. Additionally, the device flow doesn't require the CLI to bring up an HTTP server to receive the authorization code, which can also fail in certain environments.
Users can still explicitly request the code flow with
--oauth-flow=codeif desired.