Skip to content

hummingbird-qcow2: add hummingbird-ci/bootc-os based container (HMS-10414)#47

Merged
croissanne merged 1 commit intoosbuild:mainfrom
croissanne:hummingbird-qcow2
Apr 27, 2026
Merged

hummingbird-qcow2: add hummingbird-ci/bootc-os based container (HMS-10414)#47
croissanne merged 1 commit intoosbuild:mainfrom
croissanne:hummingbird-qcow2

Conversation

@croissanne
Copy link
Copy Markdown
Member

As hummingbird is based on fedora, use the same kargs.

@lzap
Copy link
Copy Markdown
Collaborator

lzap commented Apr 21, 2026

Can we merge #39 first and avoid creating those copies everywhere? That is gonna get out of control.

Also, hummingbird is quite long, hmmm :)

Copy link
Copy Markdown
Collaborator

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the long hummingbird is fine, I cannot find any release version number mentioned anywhere this is likely a streaming release.

Anyways, we just merged #39 you can now simply use qcow2-ARCH directories which hold the common files for the given image type which is this case. Let's keep it super simple for now, we can figure out better solution once we have all the image types in.

@croissanne croissanne marked this pull request as draft April 21, 2026 16:39
@ochosi ochosi changed the title hummingbird-qcow2: add hummingbird-ci/bootc-os based container hummingbird-qcow2: add hummingbird-ci/bootc-os based container (HMS-10414) Apr 22, 2026
@croissanne croissanne marked this pull request as ready for review April 24, 2026 13:29
@croissanne croissanne requested review from lzap and thozza April 24, 2026 13:36
@croissanne
Copy link
Copy Markdown
Member Author

I guess the long hummingbird is fine, I cannot find any release version number mentioned anywhere this is likely a streaming release.

Anyways, we just merged #39 you can now simply use qcow2-ARCH directories which hold the common files for the given image type which is this case. Let's keep it super simple for now, we can figure out better solution once we have all the image types in.

sadly it's a bit different because of the systemd presets.

Comment thread hummingbird-qcow2-amd64/usr/lib/bootc/kargs.d/50-kargs-x86_64.toml Outdated
Comment thread hummingbird-qcow2-arm64/usr/lib/bootc/kargs.d/50-kargs-aarch64.toml Outdated
@croissanne croissanne requested a review from ondrejbudai April 27, 2026 08:34
Copy link
Copy Markdown
Collaborator

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one blocker: systemd.firstboot=off is not in our distrodefs for RHEL or CentOS.

I would love to avoid copies at this stage, but that is not a blocker.

Comment thread hummingbird-qcow2-amd64/usr/lib/bootc/kargs.d/50-kargs-x86_64.toml Outdated
Copy link
Copy Markdown
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'm OK with the PR as is. I assume that you boot-tested the qcow2 locally? 😇

@croissanne
Copy link
Copy Markdown
Member Author

FWIW, I'm OK with the PR as is. I assume that you boot-tested the qcow2 locally? 😇

Yup, and verified that cloud-init works, and sshd comes up

thozza
thozza previously approved these changes Apr 27, 2026
@croissanne croissanne enabled auto-merge (rebase) April 27, 2026 13:36
@croissanne croissanne requested a review from lzap April 27, 2026 13:37
@croissanne croissanne requested a review from thozza April 27, 2026 14:07
Copy link
Copy Markdown
Collaborator

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You commented fixed for the copy of the same file but there are still two copies.

Okay, we can change this later.

As hummingbird is based on fedora, use the same kargs.

The base hummingbird container does not have a default root filesystem
type defined. To avoid having to pass this to composer and down to
images, just set it to ext4.
@croissanne croissanne merged commit 5b5aa43 into osbuild:main Apr 27, 2026
1 of 11 checks passed
@croissanne croissanne deleted the hummingbird-qcow2 branch April 27, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants