hummingbird-qcow2: add hummingbird-ci/bootc-os based container (HMS-10414)#47
Conversation
|
Can we merge #39 first and avoid creating those copies everywhere? That is gonna get out of control. Also, |
bd43b99 to
a45a586
Compare
lzap
left a comment
There was a problem hiding this comment.
I guess the long hummingbird is fine, I cannot find any release version number mentioned anywhere this is likely a streaming release.
Anyways, we just merged #39 you can now simply use qcow2-ARCH directories which hold the common files for the given image type which is this case. Let's keep it super simple for now, we can figure out better solution once we have all the image types in.
a45a586 to
3cb249c
Compare
sadly it's a bit different because of the systemd presets. |
lzap
left a comment
There was a problem hiding this comment.
Only one blocker: systemd.firstboot=off is not in our distrodefs for RHEL or CentOS.
I would love to avoid copies at this stage, but that is not a blocker.
thozza
left a comment
There was a problem hiding this comment.
FWIW, I'm OK with the PR as is. I assume that you boot-tested the qcow2 locally? 😇
Yup, and verified that cloud-init works, and sshd comes up |
3cb249c to
50db2e9
Compare
50db2e9 to
af309b0
Compare
lzap
left a comment
There was a problem hiding this comment.
You commented fixed for the copy of the same file but there are still two copies.
Okay, we can change this later.
As hummingbird is based on fedora, use the same kargs. The base hummingbird container does not have a default root filesystem type defined. To avoid having to pass this to composer and down to images, just set it to ext4.
af309b0 to
230946b
Compare
As hummingbird is based on fedora, use the same kargs.