Fix RHEL 10.1 installer ISO build failures (HMS-10568)#59
Merged
lzap merged 4 commits intoosbuild:mainfrom Apr 27, 2026
Merged
Conversation
bootc base images ship with an empty /boot because bootupd moves bootloader files to /usr/lib/bootupd/updates during image creation. Reinstall shim-x64 so that the required EFI binaries are present in /boot/efi/EFI, fulfilling the container-native ISO contract. This replaces the previous workaround (copying from /usr/lib/efi). Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Also drop the --target-imgref. Per upstream documentation, it is not needed in case the ref is the same as the --source-imgref. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
ondrejbudai
requested changes
Apr 27, 2026
The bootc kickstart command is available only since RHEL-10.2. Use ostreecontainer command instead. Thanks to Ondrej Budai for suggesting this. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
ondrejbudai
approved these changes
Apr 27, 2026
lzap
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The osbuild-composer
org.osbuild.grub2.isostage fails with[Errno 2] No such file or directory: '/boot/efi/EFI/redhat/shimx64.efi'because bootc base images ship with an empty/boot— bootupd moves bootloader files to/usr/lib/bootupd/updatesduring image creation. Fix this by reinstallingshim-x64so the required EFI binaries are present under/boot/efi/EFI, fulfilling the container-native ISO contract. Also correct the ISO metadata and kickstart config for RHEL 10.1.Architectural Changes
Replace the previous commented-out workaround (manually copying from
/usr/lib/efi) with adnf reinstall shim-x64approach. This is cleaner because it lets the RPM scriptlets place files in their canonical locations. A comment notes this will need to change once the Fedora BootLoaderUpdatesPhase1 change lands upstream.Key Changes
shim-x64to populate/boot/efi/EFIwith required EFI binaries, fixing theorg.osbuild.grub2.isostage failurecp -rva /usr/lib/efiworkaround (issue #50)--source-imgreftolocal-storage://and drop the now-redundant--target-imgrefostreecontainercommand in the kickstart, instead of thebootccommand, which is not available in RHEL 10.1.