Skip to content

Support uploading to libvirt #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support uploading to libvirt #300

wants to merge 1 commit into from

Conversation

FrostyX
Copy link

@FrostyX FrostyX commented Sep 13, 2025

@FrostyX FrostyX requested a review from a team as a code owner September 13, 2025 18:36
@FrostyX FrostyX requested review from lzap, bcl and achilleas-k and removed request for a team September 13, 2025 18:36
@FrostyX FrostyX mentioned this pull request Sep 16, 2025
Merged
mvo5
mvo5 reviewed Sep 22, 2025
View reviewed changes
bcl
bcl reviewed Sep 24, 2025
View reviewed changes
bcl
bcl reviewed Sep 24, 2025
View reviewed changes
bcl
bcl requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UploadAndRegister need to match the one just released in images.

@FrostyX FrostyX force-pushed the libvirt branch 3 times, most recently from 8f33e26 to d05e2d0 Compare September 24, 2025 18:26
@FrostyX
Copy link
Author

FrostyX commented Sep 24, 2025

I updated the PR, it works on my machine but CI is failing

Package libvirt-admin was not found in the pkg-config search path.
Perhaps you should add the directory containing `libvirt-admin.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libvirt-admin' not found
Package 'libvirt-admin' not found
Package 'libvirt' not found
Package 'libvirt' not found
Package 'libvirt' not found
Package 'libvirt' not found

I am trying to figure out where to specify these

@FrostyX FrostyX force-pushed the libvirt branch 2 times, most recently from 0aec36f to 7dc8240 Compare September 24, 2025 19:10
@FrostyX
Copy link
Author

FrostyX commented Sep 24, 2025

I think I fixed the CI :-)

mvo5
mvo5 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you!

@FrostyX FrostyX mentioned this pull request Sep 25, 2025
Open
@bcl bcl self-requested a review September 25, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvo5 mvo5 mvo5 approved these changes

@lzap lzap Awaiting requested review from lzap lzap is a code owner automatically assigned from osbuild/osbuild-reviewers

@achilleas-k achilleas-k Awaiting requested review from achilleas-k achilleas-k is a code owner automatically assigned from osbuild/osbuild-reviewers

@bcl bcl Awaiting requested review from bcl

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrostyX @bcl @mvo5