docs: generate manpages#504
Conversation
|
Mmm; seems to fail with on CentOS/RHEL, but not Fedora. Wonder what the actual error is. |
It means that the macro isn't expanded at all; maybe we're lacking a buildrequires for Go macros or the version in EL doesn't contain this macro. |
lzap
left a comment
lzap
left a comment
There was a problem hiding this comment.
Looks good, not sure what you mean by the macro not being expanded, it is used in the file already why it would not error out there?
Mmm; you're right. Confusing. Maybe it's only available under |
|
|
||
| func addManPageCmd(rootCmd *cobra.Command) { | ||
| manCmd := &cobra.Command{ | ||
| Use: "gen-man-pages <output-dir>", |
There was a problem hiding this comment.
For whatever it's worth I called this command doc in composer-cli. But I don't have strong feelings either way, other than consistency would be a good idea.
|
Yeah, it's not getting expanded on RHEL :) From a different PR where it works on accident: You could just write it to |
Ah because it's quoted in the other case. Ok I'll change both of them. Thanks 🙂 |
Create manpages by using Cobra's built-in ability to do so. Add a hidden command that we call in our RPM specfile to generate the pages and install them in the appropriate location. Also adds a new Makefile option to generate the manpages. Signed-off-by: Simon de Vlieger <[email protected]>
This macro doesn't exist (yet) on ELs; instead use `_bin` as the prefix. This accidentally works because install quotes the paths so they work even when not expanded. We use `_bin` in our other spec files for Go projects. Signed-off-by: Simon de Vlieger <[email protected]>
3 participants
Create manpages by using Cobra's built-in ability to do so. Add a hidden command that we call in our RPM specfile to generate the pages and install them in the appropriate location.
Also adds a new Makefile option to generate the manpages.
Looks like:
Etc.