Skip to content

Conversation

@aaruni96
Copy link
Member

Includes the elliptic curves documentation already existing under Hecke to be included into doc/main (and then also the search results).

Fixes #4187

As a note, this doesn't build on my local machine. I have the same problem I had in the other PR : #4292 (comment) , the search index is never created, and then the patching step errors out.

[ Info: Patching search index.
sed: can't read /home/aaruni/Programs/git/GitHub/Oscar.jl/docs/build/search_index.js: No such file or directory
ERROR: LoadError: failed process: Process(`sed -n '2p;3q' /home/aaruni/Programs/git/GitHub/Oscar.jl/docs/build/search_index.js`, ProcessExited(2)) [2]

It should still work, in principle. Lets see what the CI says.

@lgoettgens lgoettgens added the documentation Improvements or additions to documentation label Nov 21, 2024
docs/doc.main Outdated
"Elliptic Curves" => [
"Hecke/manual/elliptic_curves/intro.md",
"Hecke/manual/elliptic_curves/basics.md",
"Hecke/manual/elliptic_curves/number_fields.md",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is empty (except for a title). Should we still include it?

@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (5a737af) to head (d1e4d14).
Report is 238 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4338   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         645      645           
  Lines       85621    85621           
=======================================
  Hits        72354    72354           
  Misses      13267    13267           

@thofma thofma enabled auto-merge (squash) November 21, 2024 16:56
@thofma thofma merged commit d14d931 into master Nov 21, 2024
@thofma thofma deleted the ak96/add-elliptic-curves branch November 21, 2024 20:45
@lgoettgens lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for elliptic curves missing.

4 participants