Add option to always build id index #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user always needs the id index, they can force the index build even in non-slim (or slim+drop) mode by setting the `create_index` option of the `ids` setting in the define_table() Lua command to `always`. The default is `autpo` which means: Only build the index in slim mode. See osm2pgsql-dev#1854 The test runner (steps_db.py) has been extended so that the table_exists() check also checks for views, so that we can access the data in the pg_catalog.pg_indexes view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user always needs the id index, they can force the index build even in non-slim (or slim+drop) mode by setting the
create_indexoption of theidssetting in the define_table() Lua command toalways. The default isautpowhich means: Only build the index in slim mode.See #1854
The test runner (
steps_db.py) has been extended so that the table_exists() check also checks for views, so that we can access the data in thepg_catalog.pg_indexesview.