Switch middle database default format to "new" #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joto
force-pushed
the
switch-middle-db-format
branch
2 times, most recently
from
8da984e to
8ca5732
Compare
lonvia
reviewed
Feb 9, 2024
src/command-line-parser.cpp
Outdated
| // For append mode we keep old default for backwards compatibility, | ||
| // for create mode the new format is the default. | ||
| // Will be overwritten by properties setting if it exists. | ||
| options.middle_database_format = options.append ? 1 : 2; |
There was a problem hiding this comment.
Shouldn't the append case remain '0' for 'please determine from the database'?
joto
force-pushed
the
switch-middle-db-format
branch
from
8ca5732 to
3a460cd
Compare
|
I have pushed a new version which should hopefully make it more clear what's happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.