Use anonymous namespaces instead of declaring static functions #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Jun 16, 2024
src/flex-lua-table.cpp
Outdated
| flex_table_column_t *column, | ||
| std::size_t expire_outputs_size, | ||
| bool append_mode) | ||
| } // anonymous namespace |
There was a problem hiding this comment.
Too early? The functions below were all static.
There was a problem hiding this comment.
I have fixed this and rebased to current master.
This is recommended in C++ Core Guidelines SF.22 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-unnamed2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is recommended in C++ Core Guidelines SF.22
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-unnamed2
Sorry for the long PR. This basically sticks a
namespace { ... } // anonymous namespacearound all sections that had static functions and removes thestatickeyword. In some cases I moved some functions around to consolidate several anon namespace sections into one. This is not consistently done though, in some case I thought it to be better to leave the anon section in the context of the code around it.