Refactor: Simplifiy code by using std::variant for copy mgr #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Jul 9, 2024
src/db-copy-mgr.hpp
Outdated
| } | ||
|
|
||
| void flush() | ||
| { | ||
| // flush current buffer if there is one | ||
| if (m_current) { | ||
| m_processor->add_buffer(std::move(m_current)); | ||
| m_processor->send_command( | ||
| db_cmd_copy_delete_t<DELETER>{std::move(m_current)}); |
There was a problem hiding this comment.
Does m_current really need wrapping here?
There was a problem hiding this comment.
I have fixed that, rebased and force-pushed.
COPYs are handled in extra threads through a worker queue. Using std::variant instead of virtual classes simplifies the code, because we don't need the indirection through a unique_ptr any more.
This is simpler than having the connection in a unique_ptr in the worker thread. Open the connection in the main thread also means any errors happen still in the main thread where they are trivial to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit simplifies the code further.