Remove option to disable BDD tests that require Lua #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts an accidental revert from eee1cd5.
Lua is now mandatory.
This way osm2pgsql can be run without failure but the test will be quick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua is now always compiled into osm2pgsql, so there is no need to disable tests that require Lua. This should solve the issue where we accidentally keep disabling the tests without noticing.
Also reverts an accidental revert of the change that removes HAVE_LUA in the version printout. And fixes a test that unexpectedly succeeded (which we didn't see because the Lua-enabled tests didn't run).