Add get_bbox() function to geometries in Lua #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new get_bbox() function for geometries in Lua. Like the get_bbox() function on OSM objects it returns the bounding box as four numbers in a Lua array (table). Having this function on geometries allows for more flexibility, you can call it on a centroid or a projected geometry for instance. It is faster to call get_bbox() on the OSM object, because it removes the step of building the geometry first, so for those cases where this is good enough the old use is fine and is still supported. See osm2pgsql-dev#2219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new get_bbox() function for geometries in Lua. Like the get_bbox() function on OSM objects it returns the bounding box as four numbers in a Lua array (table). Having this function on geometries allows for more flexibility, you can call it on a centroid or a projected geometry for instance.
It is faster to call get_bbox() on the OSM object, because it removes the step of building the geometry first, so for those cases where this is good enough the old use is fine and is still supported.
See #2219
I have chosen the
get_bbox()name instead ofenvelope(). a) this is consistent withget_bbox()on OSM objects and b) this leaves the option for adding aenvelope()function later that returns a geometry, not a Lua array.