Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are not planning to litter the code with [[nodiscard]] #2235

Merged
merged 1 commit into from
Aug 19, 2024
Merged

We are not planning to litter the code with [[nodiscard]] #2235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ Checks: '*,-abseil-*,-altera-*,-android-cloexec-*,-bugprone-easily-swappable-par
# Lots of these, need some time to fix. (TODO)
#
# modernize-use-nodiscard
# We have a lot of these. Remove it for the time being because there are
# too many to fix quickly. (TODO)
# Doesn't really make the code clearer if it is all littered with
# [[nodiscard]]. Looks like this warning is more suited for a library
# than for normal code.
#
# modernize-use-trailing-return-type
# We are not that modern...
Expand Down
Loading