Skip to content

Use const ref params in properties code #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Use const ref params in properties code #2253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/properties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ void properties_t::set_string(std::string const &property,
m_to_update[property] = value;
}

void properties_t::set_int(std::string property, int64_t value)
void properties_t::set_int(std::string const &property, int64_t value)
{
set_string(std::move(property), std::to_string(value));
set_string(property, std::to_string(value));
}

void properties_t::set_bool(std::string property, bool value)
void properties_t::set_bool(std::string const &property, bool value)
{
set_string(std::move(property), value ? "true" : "false");
set_string(property, value ? "true" : "false");
}

void properties_t::init_table()
Expand Down
4 changes: 2 additions & 2 deletions src/properties.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class properties_t
* \param property Name of the property
* \param value Value of the property
*/
void set_int(std::string property, int64_t value);
void set_int(std::string const &property, int64_t value);

/**
* Set property to boolean value. In the database this will show up as the
Expand All @@ -72,7 +72,7 @@ class properties_t
* \param property Name of the property
* \param value Value of the property
*/
void set_bool(std::string property, bool value);
void set_bool(std::string const &property, bool value);

/**
* Initialize the database table 'osm2pgsql_properties'. It is created if
Expand Down
Loading