Skip to content

Coordinate formats list - #5685

Open
vitaliy-sova-ios wants to merge 42 commits into
masterfrom
unify_coordinate_format_picker
Open

Coordinate formats list#5685
vitaliy-sova-ios wants to merge 42 commits into
masterfrom
unify_coordinate_format_picker

Conversation

@vitaliy-sova-ios

Copy link
Copy Markdown
Contributor

No description provided.

@vitaliy-sova-ios vitaliy-sova-ios linked an issue Aug 24, 2026 that may be closed by this pull request
45 tasks
@tigrim

tigrim commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Android keeps this preference owned by CoordinateFormatSettingsStorage (preferredCoordinateFormatIdsPreference), while iOS registers it in OAAppSettings and passes it into the storage. Is this intentional for iOS preference registration / backup-import support? If yes, this looks fine, but it may be worth keeping it private/internal to OAAppSettings unless other code is expected to access it directly.

@tigrim

tigrim commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

I found a few behavior gaps compared with the Android implementation this was ported from:

  1. CoordinatesFormatViewController.swift: the Add and Edit buttons are visible, but their handlers are empty. On Android, Edit opens CoordinatesFormatEditFragment, and Add opens AddCoordinateFormatFragment. Without those flows, users cannot add, remove, or reorder preferred formats.

  2. CoordinateFormatIds.swift / BuiltInCoordinateFormat.swift: the iOS port currently includes only 6 built-in formats, while Android also has swiss_grid, swiss_grid_plus, and maidenhead. Also, iOS accepts epsg: ids in normalize, but CoordinatesFormatViewController.resolveFormats resolves only built-in formats via compactMap, so EPSG/custom grid formats coming from Android sync/import would silently disappear from the list.

  3. OAPointDescription.mm / OAQuickSearchCoordinatesViewController.mm: the new preferred format list is not wired into the places Android uses it for. Android takes the primary format from coordinateFormatSettingsStorage for quick search and share/context flows, while iOS still reads the legacy settingGeoFormat and a fixed format set. This means the new settings screen can show a preferred list that does not actually control quick access in search/context menu flows.

@tigrim

tigrim commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Since the task is still in progress, I’ll re-review the comments I left once the entire task is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify coordinate format picker across Settings, Search and Widget

2 participants