Migrate iOS route details backend to OsmAnd-shared - #5707
Open
alex-dev-neo wants to merge 15 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/osmandapp/OsmAnd-Issues/issues/1794
Summary
Migrate the iOS route-details backend and duplicated data models to
OsmAnd-shared.This is a backend migration only. It does not introduce new UI or intentionally change route-details presentation.
Changes
RouteDetailsSnapshotfrom native route calculation results.OARouteStatistics→ sharedRouteStatisticOAExitInfo→ sharedRouteExitInfoEOAAlarmInfoType→ sharedRouteEventTypeCompatibility
OAAlarmInfoas the mutable iOSOALocationPointwrapper required for navigation and tunnel aggregation.OAAlarmInfohash values despite the old iOS and shared enum ordering difference.Tests
Added or updated coverage for:
Dependency
Depends on the corresponding
OsmAnd-sharedroute-details backend changes from the Android PR osmandapp/OsmAnd#25773.