-
Notifications
You must be signed in to change notification settings - Fork 285
[BG] Add MAF orthophoto #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
[BG] Add MAF orthophoto #2796
Conversation
2942ef6
to
ef8982c
Compare
It is ready for review. Let me know if you prefer another name for |
The idea is good, but please discuss the parameter with the editor maintainers before we can merge. |
If you want, we can split this PR in two and merge just the new imagery quickly. |
@grischard, I believe @Dimitar5555 has already discussed this with @tyrasd |
I've discussed it Martin Raifer (tyrasd) already. I'm not sure if there are other editors which use ELI and also show the vintage of a given imagery. Unless there is such editor, I don't see a reason for splitting this PR. |
At least the seven editors in the readme should be consulted and not object. Schema compatibility should be kept with JOSM. The schema of the vintage geojson should be documented, and the QA scripts should check that it's accessible and valid. |
39d38ab
to
ecf63af
Compare
I've dropped the |
I'm not sure if any of the editors display the imagery date parameters we currently have? An alternative to your original PR that doesn't require schema changes would be to include multiple layers with the same endpoint and different dates. |
ecf63af
to
028db72
Compare
It won't work in iD and in other editors likely. You can start in one end of the country then move within the editor to the other end of the country and it will still show the same date and imagery. At least until you change the imagery or reload the page. |
I think it's a great idea to store vintage information for mosaics, but let's keep that in another ticket. |
@andrewharvey, is it OK to merge this now since @Dimitar5555 has removed the |
This imagery covers the entire territory of Bulgaria and was provided by the Ministry of Agriculture and Foods. There are no restrictions on its use.
About one-quarter of the imagery is updated each year, so the full dataset isn’t from a single year. To make this clearer, I’ve added a
vintage_url
parameter that points to a GeoJSON file showing when each section was captured. This parameter will be used in iD, and it can be renamed if needed. I will add it to the schema, once we confirm it's final name.The final vintage URL will be confirmed soon, but for now it is visible here:
https://gist.github.com/Dimitar5555/9ff7ee499c93148b4b4b5690889eebe3#file-maf-vintage-geojson