Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker Socket Mounting and CLI Installation for Docker Support #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Docker Socket Mounting and CLI Installation for Docker Support #308

wants to merge 1 commit into from

Conversation

tanishapritha
Copy link

Implemented Docker socket mounting (/var/run/docker.sock) and installed Docker CLI inside the container to enable interaction with the host Docker daemon. Set up the Docker group pass-through to resolve access issues.
Screenshot 2025-01-19 133526
Screenshot 2025-01-19 133956

@tanishapritha tanishapritha requested a review from tfoote as a code owner January 19, 2025 12:14
@tanishapritha tanishapritha mentioned this pull request Jan 19, 2025
Open
tfoote
tfoote requested changes Jan 19, 2025
View reviewed changes
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pr here seems to only include changes to the README did you forget to commit other charges?

Also the readme appears to be completely changed. I would expect a change like this to only have a minimal change to the readme if anything at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanishapritha @tfoote