fix: do not expect db to exist with --import-json #5438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
update-offline-doc
branch
2 times, most recently
from
ecdaeab to
a551989
Compare
Obviously, --import-json is mainly useful when db doesn't exist so drop
cvedb_orig.check_db_exists() from if statement
Moreover, do not exit after --import-json or --export-json to be
consistent with --import and --export
Finally, while at it, add --{im,ex}port-json to offline.md
Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
changed the title
ffontaine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously,
--import-jsonis mainly useful when db doesn't exist so dropcvedb_orig.check_db_exists()fromifstatementMoreover, do not exit after
--import-jsonor--export-jsonto be consistent with--importand--exportFinally, while at it, add
--{im,ex}port-jsontooffline.md